Add acquireAsync#7149
Open
dagnir wants to merge 1 commit into
Open
Conversation
This commit replaces tryAcquire with acquireAsync to better support async codepaths. acquireAsync returns a CompletableFuture that is completed when a token is successfully acquired; unlike tryAcquire, the caller is not expected to do any of their own waiting once future is complete.
dagnir
force-pushed
the
dongie/adaptive-fix-pt2
branch
from
378a48f to
7f0e04e
Compare
dagnir
commented
Jul 15, 2026
| protected Duration computeInitialBackoff(AcquireInitialTokenRequest request) { | ||
| RateLimiterTokenBucket bucket = rateLimiterTokenBucketStore.tokenBucketForScope(request.scope()); | ||
| return bucket.tryAcquire().delay(); | ||
| throw new UnsupportedOperationException("TODO"); |
Contributor
Author
There was a problem hiding this comment.
Will add impl in follow up PR.
dagnir
commented
Jul 15, 2026
| Duration backoff = super.computeBackoff(request, token); | ||
| RateLimiterTokenBucket bucket = rateLimiterTokenBucketStore.tokenBucketForScope(token.scope()); | ||
| return backoff.plus(bucket.tryAcquire().delay()); | ||
| throw new UnsupportedOperationException("TODO"); |
Contributor
Author
There was a problem hiding this comment.
Will add impl in follow up PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This commit replaces tryAcquire with acquireAsync to better support async codepaths. acquireAsync returns a CompletableFuture that is completed when a token is successfully acquired; unlike tryAcquire, the caller is not expected to do any of their own waiting once future is complete.
Modifications
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License